Update Fleet-maintained apps#47733
Closed
fleet-release wants to merge 1 commit into
Closed
Conversation
Generated automatically with cmd/maintained-apps.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Script Diff Resultsee/maintained-apps/outputs/1password/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/1password/windows.json=== Install Script (no changes) ===
=== Uninstall // 9f49925c -> eeb3b3d3 ===
--- /tmp/old.na288z 2026-06-17 05:40:40.129814250 +0000
+++ /tmp/new.JO7pL8 2026-06-17 05:40:40.129814250 +0000
@@ -1,7 +1,7 @@
# 1Password Uninstall Script
# Closes running processes before uninstalling to prevent hangs
-$product_code = '{2385DFA4-343E-42DE-9E7A-D41189885BD7}'
+$product_code = '{D56E499A-302F-403E-A362-450BCE7AD94F}'
$timeoutSeconds = 300 # 5 minute timeout
# Close any running 1Password processesee/maintained-apps/outputs/alcove/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/android-studio/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/bambu-studio/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/beeper/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/claude/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/codex-app/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/cursor/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/cursor/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/dockside/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/firefox/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/firefox@esr/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/forklift/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/framer/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/gitkraken/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/google-chrome/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/granola/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/insomnia/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/kiro-cli/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/notion/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/ollama/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/onedrive/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/postman/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/postman/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/power-bi/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/qlab/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/rive/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/sql-server-management-studio/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/sqlpro-for-mssql/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/superwhisper/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/thunderbird/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/unity-hub/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/virtualbox/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/virtualbox/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/webcatalog/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/webex/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/windows-app/windows.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/wispr-flow/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) ===ee/maintained-apps/outputs/yubico-authenticator/darwin.json=== Install Script (no changes) ===
=== Uninstall Script (no changes) === |
Contributor
WalkthroughVersion metadata was updated across 35 maintained-app JSON manifests in Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ee/maintained-apps/outputs/alcove/darwin.json`:
- Around line 9-10: The installer_url now points to a `.dmg` file (macOS disk
image), but the install script referenced by install_script_ref "bdb62bd2" still
contains extraction logic using `unzip "$INSTALLER_PATH"` which will fail for
DMG files. Update the script with ref "bdb62bd2" to replace the unzip extraction
command with the appropriate approach for DMG files, such as using `hdiutil
attach` to mount the DMG before copying the app, ensuring the extraction method
aligns with the DMG payload format.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: da47c06d-de6a-4112-970b-35c0f71e1a40
📒 Files selected for processing (40)
ee/maintained-apps/outputs/1password/darwin.jsonee/maintained-apps/outputs/1password/windows.jsonee/maintained-apps/outputs/alcove/darwin.jsonee/maintained-apps/outputs/android-studio/darwin.jsonee/maintained-apps/outputs/bambu-studio/darwin.jsonee/maintained-apps/outputs/beeper/darwin.jsonee/maintained-apps/outputs/claude/darwin.jsonee/maintained-apps/outputs/codex-app/darwin.jsonee/maintained-apps/outputs/cursor/darwin.jsonee/maintained-apps/outputs/cursor/windows.jsonee/maintained-apps/outputs/dockside/darwin.jsonee/maintained-apps/outputs/firefox/darwin.jsonee/maintained-apps/outputs/firefox@esr/darwin.jsonee/maintained-apps/outputs/forklift/darwin.jsonee/maintained-apps/outputs/framer/darwin.jsonee/maintained-apps/outputs/gitkraken/darwin.jsonee/maintained-apps/outputs/google-chrome/darwin.jsonee/maintained-apps/outputs/granola/darwin.jsonee/maintained-apps/outputs/insomnia/darwin.jsonee/maintained-apps/outputs/kiro-cli/darwin.jsonee/maintained-apps/outputs/notion/darwin.jsonee/maintained-apps/outputs/ollama/darwin.jsonee/maintained-apps/outputs/onedrive/windows.jsonee/maintained-apps/outputs/postman/darwin.jsonee/maintained-apps/outputs/postman/windows.jsonee/maintained-apps/outputs/power-bi/windows.jsonee/maintained-apps/outputs/qlab/darwin.jsonee/maintained-apps/outputs/rive/darwin.jsonee/maintained-apps/outputs/sql-server-management-studio/windows.jsonee/maintained-apps/outputs/sqlpro-for-mssql/darwin.jsonee/maintained-apps/outputs/superwhisper/darwin.jsonee/maintained-apps/outputs/thunderbird/darwin.jsonee/maintained-apps/outputs/unity-hub/darwin.jsonee/maintained-apps/outputs/virtualbox/darwin.jsonee/maintained-apps/outputs/virtualbox/windows.jsonee/maintained-apps/outputs/webcatalog/darwin.jsonee/maintained-apps/outputs/webex/darwin.jsonee/maintained-apps/outputs/windows-app/windows.jsonee/maintained-apps/outputs/wispr-flow/darwin.jsonee/maintained-apps/outputs/yubico-authenticator/darwin.json
Comment on lines
+9
to
10
| "installer_url": "https://download.tryalcove.com/Alcove.dmg", | ||
| "install_script_ref": "bdb62bd2", |
Contributor
There was a problem hiding this comment.
Update Alcove install flow for DMG payload.
Line 9 now points to a .dmg, but the script referenced by Line 10 (bdb62bd2, shown at Line 20) still extracts with unzip "$INSTALLER_PATH". That will fail installation before the app copy step.
💡 Suggested fix (install script extraction block)
-# extract contents
-unzip "$INSTALLER_PATH" -d "$TMPDIR"
+# extract contents
+MOUNT_POINT=$(mktemp -d /tmp/dmg_mount_XXXXXX)
+yes | hdiutil attach -plist -nobrowse -readonly -mountpoint "$MOUNT_POINT" "$INSTALLER_PATH" || exit 1
+sudo cp -R "$MOUNT_POINT"/* "$TMPDIR"
+hdiutil detach "$MOUNT_POINT" || true🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ee/maintained-apps/outputs/alcove/darwin.json` around lines 9 - 10, The
installer_url now points to a `.dmg` file (macOS disk image), but the install
script referenced by install_script_ref "bdb62bd2" still contains extraction
logic using `unzip "$INSTALLER_PATH"` which will fail for DMG files. Update the
script with ref "bdb62bd2" to replace the unzip extraction command with the
appropriate approach for DMG files, such as using `hdiutil attach` to mount the
DMG before copying the app, ensuring the extraction method aligns with the DMG
payload format.
Contributor
|
Closing in favor of #47774. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated ingestion of latest Fleet-maintained app data.
Summary by CodeRabbit
Chores